Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Layouts with Suspense boundaries do not stream when changing pages #1255

Closed
wesbos opened this issue Feb 21, 2025 · 1 comment · Fixed by #1257
Closed

Dynamic Layouts with Suspense boundaries do not stream when changing pages #1255

wesbos opened this issue Feb 21, 2025 · 1 comment · Fixed by #1257
Assignees

Comments

@wesbos
Copy link
Contributor

wesbos commented Feb 21, 2025

I've modified 01_template to show the issue: https://github.com/wesbos/waku-dynanic-suspense/tree/main/examples/01_template

When a layout is dynamic and there is a suspense boundary in that layout, Clicking a to changing pages waits for the entire output to be resolved.

It should change pages as soon as the unsuspended bits of the components are rendered.

My use case: I have a dynamic component in the footer of my layout. I actually don't want it to re-run every page change, but that might be another issue.

Here is a video showing the issue: https://share.cleanshot.com/7L0FXm9N

@dai-shi
Copy link
Owner

dai-shi commented Feb 22, 2025

Thanks for reporting. I think it's because of the default transition behavior. I'll look into it. I might need the transition opt-in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants