Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] message does not attach to a file and line provided, and instead all comments are in the "main comment" section #1419

Open
kadoshms opened this issue Dec 19, 2023 · 1 comment

Comments

@kadoshms
Copy link

kadoshms commented Dec 19, 2023

Describe the bug

Seems like using the message API with a file and line doesn't always add the message as a comment on the file.
I would expect that for instance passing a foo.ts with line 6, would add the comment as follows:
image

Instead, the message is created under the "main comment" only - with the following format:
image

{FILE_PATH}:L{LINE_NUMBER} - message

To Reproduce
Steps to reproduce the behavior:

  1. Create a danger rule with message on a file and line
  2. Create an MR on GitLab Self-Hosted

Expected behavior
If provided, message should be inline to the file and line as a comment.

Screenshots
See above

Your Environment
GitLab Self-Hosted
D

software version
danger.js 11.3.1
node 16.20.1
@kadoshms kadoshms added the bug label Dec 19, 2023
@kadoshms kadoshms changed the title [BUG] message does not attach to a file and line provided, and instead stace [BUG] message does not attach to a file and line provided, and instead all comments are in the "main comment" section Dec 26, 2023
@fbartho
Copy link
Member

fbartho commented Apr 11, 2024

It’s likely the issue is in one of the following files

Possibly in optional APIs that you need to override, or in how they’re submitting messages to the GitLab APIs

I don’t use GitLab, but somebody who does can probably figure it out from there! — (Does GitLab support line-level comments via API?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants