Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC1271 is out of date #4

Open
cwhinfrey opened this issue Feb 5, 2020 · 0 comments
Open

ERC1271 is out of date #4

cwhinfrey opened this issue Feb 5, 2020 · 0 comments

Comments

@cwhinfrey
Copy link

It looks like 2ccb26e reverted #2. Was that intentional? ERC1271 now specifies the following function signatur. It may be worth re-adding the switch to ERC1654 or updating the interface.

function isValidSignature(
    bytes memory _data, 
    bytes memory _signature)
    public
    view 
    returns (bytes4 magicValue);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant