fix(trstringer#75): display corect base URL if using GHE (trstringer#90)

augustomelo · web-flow · commit dd1555b1d179 · 2023-04-23T11:02:50.000-04:00
It was displaying the GH URL even though the GHE was configured, using the client.baseURL will correctly display a correct value. https://pkg.go.dev/github.com/google/go-github/v50/github#Client
diff --git a/approval.go b/approval.go
@@ -44,7 +44,7 @@ func newApprovalEnvironment(client *github.Client, repoFullName, repoOwner strin
 }
 
 func (a approvalEnvironment) runURL() string {
-	return fmt.Sprintf("https://github.com/%s/actions/runs/%d", a.repoFullName, a.runID)
+	return fmt.Sprintf("%s%s/actions/runs/%d", a.client.BaseURL.String(), a.repoFullName, a.runID)
 }
 
 func (a *approvalEnvironment) createApprovalIssue(ctx context.Context) error {

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ func newApprovalEnvironment(client *github.Client, repoFullName, repoOwner strin`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`func (a approvalEnvironment) runURL() string {`
`47`		`- return fmt.Sprintf("https://github.com/%s/actions/runs/%d", a.repoFullName, a.runID)`
	`47`	`+ return fmt.Sprintf("%s%s/actions/runs/%d", a.client.BaseURL.String(), a.repoFullName, a.runID)`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`func (a *approvalEnvironment) createApprovalIssue(ctx context.Context) error {`