Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Disable animation on pop up #42

Closed
agccie opened this issue Sep 25, 2018 · 1 comment
Closed

UI: Disable animation on pop up #42

agccie opened this issue Sep 25, 2018 · 1 comment
Labels
enhancement New feature or request verified validated that issue is resolved

Comments

@agccie
Copy link
Contributor

agccie commented Sep 25, 2018

For modal pop up, the animation is shaking (at least on my browser and likely customer's as well). Can we have this disabled by default and do a non-animated pop up?
@agccie agccie added the enhancement New feature or request label Sep 25, 2018
@Akeru
Copy link
Contributor

Akeru commented Sep 26, 2018

Will disable all animations for now

Akeru pushed a commit to Akeru/statechecker that referenced this issue Sep 26, 2018
Fix datacenter#22 and datacenter#27 by refactoring user add/edit logic
7b1088e 
Fix datacenter#28 by adding API call at load
Fix datacenter#30 and datacenter#31 by refactoring fabric add/edit logic
Fix datacenter#32
Fix datacenter#42 by disabling animation globally
Work datacenter#41 by updating CSS classes
@Akeru Akeru mentioned this issue Sep 26, 2018
Merged
agccie pushed a commit that referenced this issue Sep 26, 2018
@Akeru @agccie
Fix #22 and #27 by refactoring user add/edit logic (#43)
5844b87 
Fix #28 by adding API call at load
Fix #30 and #31 by refactoring fabric add/edit logic
Fix #32
Fix #42 by disabling animation globally
Work #41 by updating CSS classes
@agccie agccie added the verified validated that issue is resolved label Sep 26, 2018
agccie pushed a commit that referenced this issue Sep 26, 2018
@Akeru @agccie
Additional fixes (#48)
1eec154 
* Fix #22 and #27 by refactoring user add/edit logic
Fix #28 by adding API call at load
Fix #30 and #31 by refactoring fabric add/edit logic
Fix #32
Fix #42 by disabling animation globally
Work #41 by updating CSS classes

* Fix #21
Fix #44
Fix #45
Fix #46
Fix #47

* Fix typo in role checking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request verified validated that issue is resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Akeru @agccie