Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: disable buttons for non-admins #46

Closed
agccie opened this issue Sep 26, 2018 · 1 comment
Closed

UI: disable buttons for non-admins #46

agccie opened this issue Sep 26, 2018 · 1 comment
Labels
enhancement New feature or request verified validated that issue is resolved

Comments

@agccie
Copy link
Contributor

agccie commented Sep 26, 2018

Non-admins are blocked from performing the below task. Backend handles this correctly but buttons should be disabled/hidden in the UI to prevent confusion:

  1. Create/modify fabrics
  2. Create/modify snapshots
  3. Create/modify compare
  4. Create/modify definitions
  5. Create/modify users
@agccie agccie added the enhancement New feature or request label Sep 26, 2018
@Akeru Akeru mentioned this issue Sep 26, 2018
Merged
agccie pushed a commit that referenced this issue Sep 26, 2018
@Akeru @agccie
Additional fixes (#48)
1eec154 
* Fix #22 and #27 by refactoring user add/edit logic
Fix #28 by adding API call at load
Fix #30 and #31 by refactoring fabric add/edit logic
Fix #32
Fix #42 by disabling animation globally
Work #41 by updating CSS classes

* Fix #21
Fix #44
Fix #45
Fix #46
Fix #47

* Fix typo in role checking
@agccie
Copy link
Contributor Author

agccie commented Sep 26, 2018

need to add this for definitions as well (delete definition, add definition). Everything else looks good

@agccie agccie reopened this Sep 26, 2018
@agccie agccie closed this as completed in bac8afa Sep 26, 2018
@agccie agccie added the verified validated that issue is resolved label Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request verified validated that issue is resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@agccie