Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON error when Series passed to get_property_labels #79

Open
lukesmurray opened this issue Aug 8, 2019 · 1 comment
Open

JSON error when Series passed to get_property_labels #79

lukesmurray opened this issue Aug 8, 2019 · 1 comment
Labels
python api feedback Feedback for the Python Client API
Milestone
API release v1.0.1

Comments

@lukesmurray
Copy link
Contributor

lukesmurray commented Aug 8, 2019 •
edited
Loading

get_property_labels does not follow the same pattern as the rest of the API and only takes a list as input. Based on the rest of the API I would expect a Series input to output a pandas Series. Instead I get a json error.

Steps to replicate

dc.get_property_labels(pd.Series(['geoId/sch5101950']))
@lukesmurray lukesmurray changed the title JSON error where Series passed to get_property_labels JSON error when Series passed to get_property_labels Aug 8, 2019
@lukesmurray
Copy link
Contributor Author

Same issue for get_triples

@antaresc antaresc added the python api feedback Feedback for the Python Client API label Aug 9, 2019
@beets beets added this to the API release v1.0.1 milestone Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python api feedback Feedback for the Python Client API
Projects
None yet
Milestone
API release v1.0.1
Development

No branches or pull requests
3 participants
@antaresc @beets @lukesmurray