Skip to content

Commit d9d5c01

Browse files
author
Franco Springveldt
committed
FIX refactored to remove code from _config.php
1 parent e6cf037 commit d9d5c01

6 files changed

+16
-16
lines changed

_config.php

-7
Original file line numberDiff line numberDiff line change
@@ -1,8 +1 @@
11
<?php
2-
3-
/**
4-
* Fetches the name of the current module folder name.
5-
*
6-
* @return string
7-
**/
8-
define('BLOGGER_DIR', basename(dirname(__FILE__)));

src/Forms/GridField/GridFieldAddByDBField.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
namespace SilverStripe\Blog\Forms\GridField;
44

5+
use SilverStripe\Core\Manifest\ModuleLoader;
56
use UnexpectedValueException;
67
use SilverStripe\Control\Controller;
78
use SilverStripe\Core\Convert;
@@ -155,7 +156,7 @@ public function setDataObjectField($field)
155156
*/
156157
public function getHTMLFragments($gridField)
157158
{
158-
Requirements::javascript(BLOGGER_DIR . '/js/gridfieldaddbydbfield.js');
159+
Requirements::javascript(ModuleLoader::getModule('silverstripe/blog')->getRelativeResourcePath('js/gridfieldaddbydbfield.js'));
159160

160161
/**
161162
* @var DataList $dataList

src/Forms/GridField/GridFieldBlogPostState.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace SilverStripe\Blog\Forms\GridField;
44

55
use SilverStripe\Blog\Model\BlogPost;
6+
use SilverStripe\Core\Manifest\ModuleLoader;
67
use SilverStripe\Lumberjack\Forms\GridFieldSiteTreeState;
78
use SilverStripe\View\Requirements;
89

@@ -19,7 +20,7 @@ class GridFieldBlogPostState extends GridFieldSiteTreeState
1920
public function getColumnContent($gridField, $record, $columnName)
2021
{
2122
if ($columnName == 'State') {
22-
Requirements::css(BLOGGER_DIR . '/css/cms.css');
23+
Requirements::css(ModuleLoader::getModule('silverstripe/blog')->getRelativeResourcePath('css/cms.css'));
2324
if ($record instanceof BlogPost) {
2425
$modifiedLabel = '';
2526

src/Model/Blog.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
use SilverStripe\Control\Controller;
1515
use SilverStripe\Control\RSS\RSSFeed;
1616
use SilverStripe\Core\Convert;
17+
use SilverStripe\Core\Manifest\ModuleLoader;
1718
use SilverStripe\Forms\GridField\GridField;
1819
use SilverStripe\Forms\ListboxField;
1920
use SilverStripe\Forms\NumericField;
@@ -141,8 +142,9 @@ class Blog extends Page implements PermissionProvider
141142
*/
142143
public function getCMSFields()
143144
{
144-
Requirements::css(BLOGGER_DIR . '/css/cms.css');
145-
Requirements::javascript(BLOGGER_DIR . '/js/cms.js');
145+
$module = ModuleLoader::getModule('silverstripe/blog');
146+
Requirements::css($module->getRelativeResourcePath('css/cms.css'));
147+
Requirements::javascript($module->getRelativeResourcePath('js/cms.js'));
146148

147149
$this->beforeUpdateCMSFields(function ($fields) {
148150
if (!$this->canEdit()) {

src/Model/BlogMemberExtension.php

+4-3
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use SilverStripe\Assets\Image;
66
use SilverStripe\Blog\Forms\GridField\GridFieldConfig_BlogPost;
77
use SilverStripe\Blog\Model\BlogPost;
8+
use SilverStripe\Core\Manifest\ModuleLoader;
89
use SilverStripe\Forms\FieldList;
910
use SilverStripe\Forms\GridField\GridField;
1011
use SilverStripe\Forms\Tab;
@@ -107,9 +108,9 @@ public function updateCMSFields(FieldList $fields)
107108
$fields->removeFieldFromTab('Root', 'BlogPosts');
108109

109110
// Construct a better posts tab.
110-
111-
Requirements::css(BLOGGER_DIR . '/css/cms.css');
112-
Requirements::javascript(BLOGGER_DIR . '/js/cms.js');
111+
$module = ModuleLoader::getModule('silverstripe/blog');
112+
Requirements::css($module->getRelativeResourcePath('css/cms.css'));
113+
Requirements::javascript($module->getRelativeResourcePath('js/cms.js'));
113114

114115
$tab = Tab::create('BlogPosts', _t(__CLASS__ . '.TABBLOGPOSTS', 'Blog Posts'));
115116

src/Model/BlogPost.php

+4-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
use SilverStripe\Blog\Model\BlogPostFilter;
1010
use SilverStripe\Blog\Model\BlogTag;
1111
use SilverStripe\Control\Controller;
12+
use SilverStripe\Core\Manifest\ModuleLoader;
1213
use SilverStripe\Forms\DatetimeField;
1314
use SilverStripe\Forms\HiddenField;
1415
use SilverStripe\Forms\HTMLEditor\HTMLEditorField;
@@ -208,8 +209,9 @@ public function isAuthor($member = null)
208209
*/
209210
public function getCMSFields()
210211
{
211-
Requirements::css(BLOGGER_DIR . '/css/cms.css');
212-
Requirements::javascript(BLOGGER_DIR . '/js/cms.js');
212+
$module = ModuleLoader::getModule('silverstripe/blog');
213+
Requirements::css($module->getRelativeResourcePath('css/cms.css'));
214+
Requirements::javascript($module->getRelativeResourcePath('js/cms.js'));
213215

214216
$this->beforeUpdateCMSFields(function ($fields) {
215217
$uploadField = UploadField::create('FeaturedImage', _t(__CLASS__ . '.FeaturedImage', 'Featured Image'));

0 commit comments

Comments
 (0)