-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ecto 3 #12
Comments
I took the implementation from appsignal/appsignal-elixir#415 Should be backwards compatible. Closes #12
Thank you for adding Ecto 3, could you also publish this version to hex? |
Also looking forward to a new release :) |
Any information on how to access this version would more than welcome :), would this have to be from the repository I guess |
Listing as a git dependency works fine for us: {:prometheus_ecto, git: "https://github.com/deadtrickster/prometheus-ecto"} |
If you want to lock the dependency to a certain commit you can also do {:prometheus_ecto, github: "deadtrickster/prometheus-ecto", ref: "650a403183f6a2fb6b682d7fbcba8bf9d24fe1e4"} The main reason I am waiting on the new release is because having mix fetch the dependency via git means that the dep has a .git directory. As a result that gets omitted during our CI build as it is not an untracked directory (GitLab CI). As a result we had to add a specific override for this package in our CI configuration. Not a huge problem, but something that was a little tricky to track down. |
1.4.0 |
Thanks a million!! |
One thing not stated in ecto 3 release notes is that it seems to remove the
loggers:
configuration key in favour of using https://github.com/elixir-telemetry/telemetryhttps://hexdocs.pm/ecto/Ecto.Repo.html#module-telemetry-events
The text was updated successfully, but these errors were encountered: