Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that a map with AP and node AP of "private (owner only)" has error when owner attempts to add a child node #343

Closed
Venryx opened this issue Aug 23, 2024 · 2 comments

Comments

@Venryx
Copy link
Collaborator

Venryx commented Aug 23, 2024

No description provided.

@Venryx
Copy link
Collaborator Author

Venryx commented Sep 26, 2024

Fixed this by changing the RLS policy for "commandRuns" table to always allow the "actor" for the command-run be able to access the entry.

However, this should have been unnecessary in the cases I tested, since the user's "addToStream" setting was true, and they should have had access to all of the targets in "c_accessPolicyTargets".

Ignoring this oddity for now though... :|

@Venryx Venryx closed this as completed Sep 26, 2024
@Venryx
Copy link
Collaborator Author

Venryx commented Sep 26, 2024

Ignore "oddity" mentioned in previous comment; I forgot that the "base permission" a user has to access their own entry is reliant entirely on these "is_user_creator" checks. (ie. a "Private (owner only)" permission policy returns "false" for "do_policies_allow_access" ALWAYS)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

1 participant