Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove subdomain from baseUrls and add as separate table #21

Closed
jogli5er opened this issue May 31, 2018 · 1 comment
Closed

Remove subdomain from baseUrls and add as separate table #21

jogli5er opened this issue May 31, 2018 · 1 comment
Assignees
@jogli5er
Labels
bug Something isn't working

Comments

@jogli5er
Copy link
Member

The current solution has the following issue: We stored the subdomain as a denormalized column directly inside the baseUrls table. This, however, leads to the issue, that we now have multiple entries per baseUrl.
Will be solved by putting those subdomains in a simple separate table, which than can be joined with the baseUrl Table.
@jogli5er
Copy link
Member Author

As discussed today, we should shift this to the paths table, since there it does not hurt to store the denormalized data, and we do not need another join to compose the urls to download

@jogli5er jogli5er added the bug Something isn't working label May 31, 2018
@jogli5er jogli5er self-assigned this May 31, 2018
jogli5er added a commit that referenced this issue Jun 5, 2018
@jogli5er
Remove subdomain from baseUrls and store it in paths
83e2fb0 
This is still a denormalized column, however, otherwise we'd need
to do always an additional join on the "subdomains" table before we
can return the next entries to be downloaded.
[#21]
@jogli5er jogli5er closed this as completed Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jogli5er jogli5er

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jogli5er