Skip to content

Commit d7d7bf7

Browse files
authoredDec 9, 2024··
Improve PR template (#2626)
1 parent fdc8722 commit d7d7bf7

File tree

1 file changed

+28
-0
lines changed

1 file changed

+28
-0
lines changed
 

‎.github/PULL_REQUEST_TEMPLATE.md

+28
Original file line numberDiff line numberDiff line change
@@ -4,3 +4,31 @@ Brief description of what this PR is about
44

55
- If this change is a backward incompatible change, why must this change be made?
66
- Interesting edge cases to note here
7+
8+
## Type of change
9+
10+
Please delete options that are not relevant.
11+
12+
- [ ] Bug fix (non-breaking change which fixes an issue)
13+
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
14+
- [ ] New feature (non-breaking change which adds functionality)
15+
- [ ] This change requires a documentation update
16+
17+
## Checklist:
18+
19+
- [ ] Have you [manually built the docker image](https://github.com/deepjavalibrary/djl-serving/blob/master/serving/docker/README.md#build-docker-image) and verify the change?
20+
- [ ] Have you run related tests? Check [how to set up the test environment here](https://github.com/deepjavalibrary/djl-serving/blob/master/.github/workflows/integration_execute.yml#L72); One example would be `pytest tests.py -k "TestCorrectnessLmiDist" -m "lmi_dist"`
21+
- [ ] Have you added tests that prove your fix is effective or that this feature works?
22+
- [ ] Has code been commented, particularly in hard-to-understand areas?
23+
- [ ] Have you made corresponding changes to the documentation?
24+
25+
## Feature/Issue validation/testing
26+
27+
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
28+
Please also list any relevant details for your test configuration.
29+
30+
- [ ] Test A
31+
Logs for Test A
32+
33+
- [ ] Test B
34+
Logs for Test B

0 commit comments

Comments
 (0)
Please sign in to comment.