Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look Into Allowing Regex in InNamespace #582

Open
TristanHoladay opened this issue Feb 16, 2024 · 3 comments · May be fixed by #1156
Open

Look Into Allowing Regex in InNamespace #582

TristanHoladay opened this issue Feb 16, 2024 · 3 comments · May be fixed by #1156
Assignees
@cmwylie19
Labels
enhancement New feature or request large large

Comments

@TristanHoladay
Copy link

Is your feature request related to a problem? Please describe.

For uds-core policy exemptions, there might be a case for optionally locking down which namespace the operator watches for Exemption CRs. With the current implementation of .InNamespace(), it does not look to be possible to set it to a single namespace or list / all namespaces based on env var. (e.g. .InNamespace(process.env.EXEMPTION_NS))

Describe the solution you'd like

  • Given an admin wants the option to allow single or all namespaces in .InNamespace(), or maybe namespaces that fit a pattern
  • he or she could use a regex patterns like so .InNamspace(".*") , .InNamespace("uds-policy-exemptions"), .InNamespace("*-policy-exemptions")

Describe alternatives you've considered

The alternative is to do this as the module author in the validator and not use .InNamespace().
@TristanHoladay TristanHoladay added the enhancement New feature or request label Feb 16, 2024
@jeff-mccoy
Copy link
Member

I think we could add something for this, but it wouldn't work really for watch as that modifies a URL to the API server. We also support multiple (array) of namespaces.

@cmwylie19 cmwylie19 added the NEEDS ADR needs adr label Feb 18, 2024
@cmwylie19
Copy link
Collaborator

closing this for now as there has been a workout set into place

@cmwylie19 cmwylie19 reopened this Sep 13, 2024
@cmwylie19 cmwylie19 removed the NEEDS ADR needs adr label Sep 13, 2024
@cmwylie19
Copy link
Collaborator

There is an ask for this, lets get it prioritized!

@cmwylie19 cmwylie19 self-assigned this Sep 13, 2024
@cmwylie19 cmwylie19 linked a pull request Sep 18, 2024 that will close this issue
Draft
8 tasks
@cmwylie19 cmwylie19 added the large large label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmwylie19 cmwylie19

Labels
enhancement New feature or request large large
Projects
Pepr Project Board
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: regex filters for namespace and name defenseunicorns/pepr
3 participants
@jeff-mccoy @cmwylie19 @TristanHoladay