Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Let's Encrypt support #189

Closed
technosophos opened this issue Jul 28, 2021 · 5 comments · Fixed by #482
Closed

Let's Encrypt support #189

technosophos opened this issue Jul 28, 2021 · 5 comments · Fixed by #482
Labels
API Issues or pull requests that affect the API enhancement New feature or request
Milestone

Comments

@technosophos
Copy link

While this isn't as pressing as #188, we do at some point want to have Let's Encrypt support.

Ideally, what we would want, UX-wise, is the user to choose their domain, and then indicate that they want SSL certificates generated for them. This would likely require the user to do something with a TXT record in their DNS provider.

@technosophos technosophos added the enhancement New feature or request label Jul 28, 2021
@bacongobbler
Copy link
Contributor

let's see if this is feasible for 0.2.

@bacongobbler bacongobbler added this to the 0.2.0 milestone Sep 9, 2021
@bacongobbler
Copy link
Contributor

bacongobbler commented Jan 17, 2022

For YarpReverseProxy: https://github.com/natemcmaster/LettuceEncrypt

@bacongobbler
Copy link
Contributor

bacongobbler commented Jan 17, 2022

Hmm... Doesn't look like we're able to issue separate certificates for each application at this time: natemcmaster/LettuceEncrypt#236

The project is in maintenance mode, so it's unlikely this feature will be implemented unless we spend the time to contribute this feature. Also judging by natemcmaster/LettuceEncrypt#236 (comment) it's unlikely it'll be merged if we contribute a PR...

@bacongobbler
Copy link
Contributor

deferring to 0.3.0 in favour of #384.

@bacongobbler bacongobbler modified the milestones: v0.2.0, v0.3.0, v0.4.0 Jan 21, 2022
@bacongobbler bacongobbler removed this from the v0.4.0 milestone Jan 31, 2022
@bacongobbler bacongobbler added the API Issues or pull requests that affect the API label Feb 17, 2022
@benschop-it
Copy link

benschop-it commented Feb 21, 2022

I have implemented the separate certificates feature in my fork at https://github.com/benschop-it/LettuceEncrypt-Benschop-IT.
This makes it possible to create a certificate per set of domains.
Some extra tests still need to be added.
Feel free to comment.

@bacongobbler bacongobbler linked a pull request Mar 15, 2022 that will close this issue
@bacongobbler bacongobbler added this to the v0.5.0 milestone Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API Issues or pull requests that affect the API enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants