Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react dependency to allow version 18 #568

Open
walkerkd opened this issue Apr 29, 2023 · 3 comments
Open

Update react dependency to allow version 18 #568

walkerkd opened this issue Apr 29, 2023 · 3 comments

Comments

@walkerkd
Copy link

Currently there is the following dependency in the project.json file:

  "peerDependencies": {
    "boardgame.io": ">=0.42.0",
    "react": "^16 || ^17"
  },

However boardgame.io now works with react version 18 since the 0.50.1.
Is there any reason why this dependency could not be updated to include react 18?

@on3iro
Copy link

on3iro commented May 6, 2023

hi - I already created a PR for this, but apparently @delucis does currently not actively maintain this library :(
I am considering a fork at this point, but maybe @delucis will chime in before that

@on3iro
Copy link

on3iro commented May 6, 2023

on a side note: even though npm will tell you that the peer dependency is incorrect, you can still use the current version of this library with bgio and react 18 without any issues.

@walkerkd
Copy link
Author

walkerkd commented May 6, 2023

I have been successfully using it with react 18 ... the problem is when I want to update all my dependencies with the command npm update it the fails due to this dependency check. I have worked around it for now but it would be much nicer if the dependency was updated.

I think @delucis was probably the last of the active developers of boardgame.io (at least he was the person who responded with help when I started out with boardgame.io). But there have been no changes for quite some time which suggests to me that the main developers have moved onto other things. Which is a pity because I found this a great framework for writing my board games in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants