Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using re-frame's subscription cache in the query parser #6

Open
julienfantin opened this issue Jul 24, 2017 · 0 comments
Open

Comments

@julienfantin
Copy link
Contributor

The parser implementation for re-frame currently uses reagent's make-reaction thus bypassing the re-frame subscription cache.

We could and probably should leverage the cache by automatically registering our subscription handler and instead use re-frame/subscribe in the parser's implementation.

We also currently don't have benchmarks for the re-frame integration and should write those first in order to compare the performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant