Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use urlpattern instead of path-to-regex for registry completions #13746

Closed
crowlKats opened this issue Feb 23, 2022 · 0 comments
Closed

use urlpattern instead of path-to-regex for registry completions #13746

crowlKats opened this issue Feb 23, 2022 · 0 comments
Labels
breaking change a change or feature that breaks existing semantics lsp related to the language server refactor upstream Changes in upstream are required to solve these issues

Comments

@crowlKats
Copy link
Member

Currently we use a custom implementation of path-to-regex just for registry completions; ideally we'd use the rust-urlpattern crate instead by exposing some of its internal methods. However, a blocker for this is whatwg/urlpattern#73, and also the fact that this change would be breaking, but releasing a v3 currently would make very little sense, as a v2 was released fairly recently and only deno.land has upgraded, whereas crux.land & nest.land still use v1.

@crowlKats crowlKats added breaking change a change or feature that breaks existing semantics lsp related to the language server refactor upstream Changes in upstream are required to solve these issues labels Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change a change or feature that breaks existing semantics lsp related to the language server refactor upstream Changes in upstream are required to solve these issues
Projects
None yet
Development

No branches or pull requests

2 participants