Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployctl deploy when using deno.json config offers to add duplicate node_modules exclude patterns #307

Open
NReilingh opened this issue Apr 16, 2024 · 0 comments

Comments

@NReilingh
Copy link

I am running deployctl deploy in a deno project with no package.json or node_modules folders. I have allowed deployctl to write configuration to deno.jsonc so that I can run deployctl deploy with no arguments. However when I do this, deployctl complains that the config used differs from config found in deno.jsonc, and offers to overwrite it with --save-config. If I allow this, it adds a duplicate entry to exclude "**/node_modules" on each run:

? Writing to the config file '[...]/deno.jsonc' will remove any existing comment and format it as a plain JSON file. Is that ok? [y/N] n
  i I understand. Here's the config I wanted to write:
  "deploy": {
     ...
  -  "exclude": ["**/node_modules","**/node_modules","**/node_modules"]
  +  "exclude": ["**/node_modules","**/node_modules","**/node_modules","**/node_modules"]
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant