Skip to content
This repository was archived by the owner on Jan 16, 2018. It is now read-only.

Enable fully mcritic testing #204

Closed
jbalsas opened this issue Dec 6, 2017 · 3 comments · Fixed by #235
Closed

Enable fully mcritic testing #204

jbalsas opened this issue Dec 6, 2017 · 3 comments · Fixed by #235

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Dec 6, 2017

We are currently ignoring a lot of packages from soy linting because it gives us problems. We need to enable it again or we risk introducing bugs and inconsistencies.

@carloslancha
Copy link
Collaborator

For this we need to provide mcritic the ability to recognize correctly the modules imports.

@jbalsas
Copy link
Contributor Author

jbalsas commented Dec 11, 2017

This is already implemented in mcritic, and we're using it here

The problem is that we have 2 import flavours:

  • import 'clay-icon';
  • import './ClayFooBase'

The same re-write won't work for the second import, so we need to add the option of multiple import rewrites :(

@carloslancha
Copy link
Collaborator

In fact we have 3 import flavours:

  • import 'clay-icon';
  • import './ClayFooBase'
  • import {ClayActionsDropdown} from 'clay-dropdown'

So we need to take in account also the named exports. I've send a pr to fix both problems: deprecate/metal-soy-critic#14

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants