Skip to content
This repository was archived by the owner on Sep 6, 2018. It is now read-only.

Feedback for parsed files that have no issues #4

Closed
robframpton opened this issue Mar 22, 2017 · 3 comments
Closed

Feedback for parsed files that have no issues #4

robframpton opened this issue Mar 22, 2017 · 3 comments
Assignees

Comments

@robframpton
Copy link

Hey guys, awesome idea for a tool!

The first time I ran it on a file, it didn't find any issues so there was no output. This made me think it was potentially a bug, and I wasn't sure if it actually read the file or not.

It might be nice to have output that lists all files that pass your checks, similar to test output which lists both the tests that pass and the ones that fail. Maybe something like...

The following 1 file(s) passed all checks:

File - src/SomeFile.soy
@mthadley
Copy link
Collaborator

@Robert-Frampton Sounds like a great idea! There are still a lot of improvements to be made in the usability.

@ethib137
Copy link
Collaborator

I like this idea, but it would be great to also include the option -q or --quiet that would not print out anything for files with no errors.

@mthadley mthadley assigned mthadley and unassigned mthadley Mar 22, 2017
@ethib137 ethib137 self-assigned this Mar 22, 2017
@ethib137
Copy link
Collaborator

Fixed by: #6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants