-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why Is --workspace-folder
Required. Can we default to $PWD?
#29
Comments
--workspace-folder
Required or Default to $PWD?--workspace-folder
Required. Can we default to $PWD?
Even more confusing is the devcontainer build [path] which still require --workspace-folder, seems like a bug, either path or workspace-folder but not both please. |
Having to type |
And add support to specify using an ENV variable as well, DEVCONTAINER_WORKSPACE_FOLDER or whatever. |
I've created a PR for this. |
I've created a PR #425, with a basic check if a @hpe-ykoehler Currently, I'm not convinced if an ENV variable is needed. Do you have a use case for that? |
@MunsMan no, but convention is that config option can be controlled by cli argument, env or config file in that order of priority. Agree env may appears less useful, but devcontainer should use a CLI framework that handles all those details (such as Cobra if written in Go) no? |
I'd suggest not to add the environment variable support unless someone asks. |
I added this function to my function dev() {
devcontainer $1 --workspace-folder . ${@: 2}
} Now I can just call Maybe it helps someone while the Issue exists. |
Hi 👋 Thanks for all the suggestions, and growing interest on this issue. We agree that the |
Polite ping :) I see three people have attempted to do this in a smart way (recursing up parent directories looking for either |
I found it odd that this parameter was required when using
devcontainer up
and was wondering why and if that was intentional. Not sure if it is also required in other commands ( just learning here ) but did want to share it felt odd to do this.$ devcontainer up --workspace-folder .
The text was updated successfully, but these errors were encountered: