Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version tags for docker-outside-of-docker #1122

Open
rubensa opened this issue Sep 13, 2024 · 5 comments
Open

Missing version tags for docker-outside-of-docker #1122

rubensa opened this issue Sep 13, 2024 · 5 comments

Comments

@rubensa
Copy link
Contributor

rubensa commented Sep 13, 2024

Looks like last docker-outside-of-docker tag is feature_docker-outside-of-docker_1.3.2 (for version 1.3.2 from January).

Following versions (1.4.0, 1.4.1, 1.4.2, 1.4.3, 1.4.4, 1.4.5, 1.5.0) have not been tagged (see: https://github.com/devcontainers/features/commits/main/src/docker-outside-of-docker/devcontainer-feature.json).

Could you, please, add tags for the missing releases (so it is easy to get the code at specific version)? (and keep that tagging for future releases, like this).

@rubensa
Copy link
Contributor Author

rubensa commented Sep 13, 2024

Looks like the same is happening for other features.

For example, last tag for node is feature_node_1.4.0 where the last code is 1.6.0.

@rubensa
Copy link
Contributor Author

rubensa commented Sep 13, 2024

Looks like the tagging support was introduced in devcontainers/action version v1.3.0 but it's not working since last February so might me a bug silently introduced in latest version v1.4.2 released on Feb 16 ?

@rubensa
Copy link
Contributor Author

rubensa commented Sep 13, 2024

Looks like automatic tagging is failing. For example, in last release execution, in the log there is the message:

Adding repo tag 'feature_desktop-lite_1.2.5'...
Warning: Failed to automatically add repo tag, manually tag with:   'git tag feature_desktop-lite_1.2.5 b0667c5589bfe1b382c49392c58fe4c9433f1fde'

@rubensa
Copy link
Contributor Author

rubensa commented Sep 13, 2024

The message comes from here.

@rubensa
Copy link
Contributor Author

rubensa commented Sep 13, 2024

As far as I can see, the culprit might be the replacement from jsonc-parser to json5 that might be, somehow, making the call with octokit to create the tag, to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant