Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate package for interfaces? #74

Closed
codymullins opened this issue Aug 26, 2024 · 7 comments · Fixed by #88
Closed

Separate package for interfaces? #74

codymullins opened this issue Aug 26, 2024 · 7 comments · Fixed by #88

Comments

@codymullins
Copy link

codymullins commented Aug 26, 2024

Hey there, I'm trying to understand where this project fits.

I see the Devlooped.CloudActors package has a dependency on Orleans.Server, and this package includes the interfaces for IActorCommand, etc.

How do you envision this being used? For example, do you foresee these actors only being for internal usage? Suppose a system (FOO) is built with these actors. The system has clients (BAR) that need to connect to it to perform operations. Would it be expected that something else sits in front of this, e.g. an API? Or could a nuget package be published that allows BAR to call FOO using the message bus?

Back this issue
Back this issue

@kzu
Copy link
Member

kzu commented Sep 2, 2024

Hi there!

I have a work in progress branch that decouples the server from the main package for precisely this. The idea is that your business logic can be completely ignorant of Orleans, and you can simply use the message bus to invoke the logic from anywhere in the app.

Due to a current limitation/bug in orleans, I haven't been able to merge and ship that yet. I'm hoping that will be fixed eventually and I'll move forward with the split.

@samcov
Copy link

samcov commented Sep 3, 2024

Very good!!! Looking forward to that release!

@kzu
Copy link
Member

kzu commented Sep 3, 2024

Please go upvote the issue in Orleans so we can get more traction 🙏

@samcov
Copy link

samcov commented Sep 3, 2024

Done!

@johnkattenhorn
Copy link

Done too!

@kzu
Copy link
Member

kzu commented Oct 15, 2024

The fix is now in, YAY!. So I'm just waiting for it to ship so I can move forward with this

@kzu
Copy link
Member

kzu commented Nov 19, 2024

Orleans just shipped v9 last week which now contains the required fix. So I can now move forward with the split :)

@kzu kzu closed this as completed in #88 Nov 19, 2024
@devlooped devlooped locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@kzu @johnkattenhorn @samcov @codymullins and others