From 73f0e94a9670d753a3f1a22bf6e32e9fb67a11fe Mon Sep 17 00:00:00 2001 From: Daniel Fuchs Date: Fri, 10 Jan 2025 15:09:21 +0000 Subject: [PATCH] Review feedback, renamed 'received' parameter to 'processed' --- .../jdk/internal/net/http/WindowUpdateSender.java | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java b/src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java index fbbb3928d4d0d..2da472bfbc3d8 100644 --- a/src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java +++ b/src/java.net.http/share/classes/jdk/internal/net/http/WindowUpdateSender.java @@ -117,24 +117,24 @@ abstract class WindowUpdateSender { * the caller wants to buffer. */ boolean canBufferUnprocessedBytes(int len) { - long buffered, rcv; + long buffered, processed; // get received before unprocessed in order to avoid counting // unprocessed bytes that might get unbuffered asynchronously // twice. - rcv = received.get(); + processed = received.get(); buffered = unprocessed.addAndGet(len); - return !checkWindowSizeExceeded(rcv, buffered); + return !checkWindowSizeExceeded(processed, buffered); } // adds the provided amount to the amount of already - // received and processed bytes and checks whether the + // processed and processed bytes and checks whether the // flow control window is exceeded. If so, take // corrective actions and return true. - private boolean checkWindowSizeExceeded(long received, long len) { + private boolean checkWindowSizeExceeded(long processed, long len) { // because windowSize is bound by Integer.MAX_VALUE // we will never reach the point where received.get() + len // could overflow - long rcv = received + len; + long rcv = processed + len; return rcv > windowSize && windowSizeExceeded(rcv); }