Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Working #27

Open
OLH21 opened this issue Jul 5, 2023 · 5 comments
Open

Stop Working #27

OLH21 opened this issue Jul 5, 2023 · 5 comments

Comments

@OLH21
Copy link

OLH21 commented Jul 5, 2023

Was ok, it has stop generating link, old links show ok, and seems to work because it shows an error message if you do not have a link selected. disabled all other plugin and theme and it's still the same. Maybe it's the latest obsidian update :)

@dhamaniasad
Copy link
Owner

Should be working now

@OLH21
Copy link
Author

OLH21 commented Jul 5, 2023

Can we have a hint on what was the problem ? is ther and external server call ? thx anyway
BTW it has never been working with all link some refuse to work whatever what's the reason ?

@dhamaniasad
Copy link
Owner

Yes there's an external server call, and that server had been shut down. It uses opengraph or meta tags to fetch the link description, if those are missing it'll fail to work. Can you share an example link it didn't work?

The reason we need the server is because of CORS, where servers block requests for security, so if I'm on hackersite.com it's not able to make requests to google.com on my behalf. Obsidian runs in a browser environment where CORS is respected and on servers it's not. So without a server a lot of links would fail to work.

@kaykhan
Copy link

kaykhan commented Aug 19, 2023

Has this stopped working again, when i click the ribbon it just says "Select a URL to convert to a rich link" but ive already highlighted the link?

@OLH21
Copy link
Author

OLH21 commented Jan 24, 2024

Stopped working on my side too ( i have a waiting message only) , don't know when it begins since it's been a while i havent used it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants