Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Question] New icons? #10

Open
1 of 2 tasks
Real-John-Cheung opened this issue Jul 19, 2021 · 3 comments
Open
1 of 2 tasks

[Question] New icons? #10

Real-John-Cheung opened this issue Jul 19, 2021 · 3 comments
Labels
question Further information is requested

Comments

@Real-John-Cheung
Copy link
Collaborator

Real-John-Cheung commented Jul 19, 2021 •
edited
Loading

Should we create some new icons for

  • disable/enable ad replacement button on pop-up page (in UBO it is the button for toggle hiding element so it is an eye)
    the middle one
    圖片

  • toggle pop-up page button on logger page
    the right one
    圖片
@Real-John-Cheung Real-John-Cheung added the question Further information is requested label Jul 19, 2021
@dhowe
Copy link
Owner

dhowe commented Jul 19, 2021

I think we can leave existing icons, as long as we replace ublock icons with adlipo (right one below):

image

@Real-John-Cheung
Copy link
Collaborator Author

replaced in 6d7f626
the basic ui replacement is near done

@dhowe
Copy link
Owner

dhowe commented Jul 20, 2021

excellent, let me know when I should test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dhowe @Real-John-Cheung