New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce cyclomatic complexity 33 in AWS provisioner #298

Open

dirien opened this issue Nov 24, 2021 · 0 comments

Labels

cloud-provider enhancement good first issue

Owner

dirien commented Nov 24, 2021

The AWS provisioner has a function with a very high cyclomatic

pkg/cloud/aws/aws.go:115:1: cyclomatic complexity 33 of func `(*Aws).CreateServer` is high (> 30) (gocyclo)
func (a *Aws) CreateServer(args automation.ServerArgs) (*automation.RessourceResults, error) {

We should split the fn to reduce the complexity

dirien added enhancement good first issue cloud-provider labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment