Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback typescript as peer-dependency at all #1675

Open
2 tasks
renatobenks opened this issue Oct 28, 2021 · 0 comments
Open
2 tasks

Rollback typescript as peer-dependency at all #1675

renatobenks opened this issue Oct 28, 2021 · 0 comments
Assignees
Labels
bug Something isn't working upstream Issue originates from dependency

Comments

@renatobenks
Copy link
Member

renatobenks commented Oct 28, 2021

Bug Report

Describe the bug

Basically, within the latest changes that came in, users not using typescript will face some troubles installing docz, because typescript was been added as peer-dependency, which introduced this new breaking-change that it's not interesting for any of us.

To Reproduce

  1. Install docz (npm install docz —-save-dev) where you don't have typescript.
  2. See error in console

Expected behavior

Users not using typescript and their codebases should be able still to install and use docz.

Steps:

  • rollback typescript as peer-dependency and find a manageable way to compat user-land typescript version over the internally used one.
  • set typescript only conditionally as a peer-dependency in a way that will work to users using typescript, based on flag typescript: true from config

Environment

  • docz version: 2.3.3-alpha.0

Additional context/Screenshots

@renatobenks renatobenks added bug Something isn't working roadmap upstream Issue originates from dependency labels Oct 28, 2021
@renatobenks renatobenks self-assigned this Oct 28, 2021
@renatobenks renatobenks removed this from the [v3] Back on Track — 2.4 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Issue originates from dependency
Projects
None yet
Development

No branches or pull requests

1 participant