Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruction or script to build package to be used by gamechanger/frontend #4

Open
neofob opened this issue Aug 17, 2023 · 0 comments
Open

Comments

@neofob
Copy link

neofob commented Aug 17, 2023

We need instruction and/or script to build the .tgz package to be used in gamechanger-web/frontend/package.json:21 when we build the docker image.

The command yarn build in gamechanger-web/frontend at the moment does not work because the package from https://github.com/dod-advana/advana-module-platform-ui/releases does not work with the mentioned above command.

node@f22d9ab6209f:/opt/app-root/src/frontend$ yarn build               
yarn run v1.22.19
$ DISABLE_ESLINT_PLUGIN=true react-app-rewired --openssl-legacy-provider --max_old_space_size=16000 build && npx compress-cra
Creating an optimized production build...
Failed to compile.

./src/App.js
Cannot find module: '@dod-advana/advana-platform-ui/dist/ClassificationBanner'. Make sure this package is installed.

You can install this package by running: yarn add @dod-advana/advana-platform-ui/dist/ClassificationBanner.


error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Note:

Repository/location Package Name Dependency Package Version
advana-module-platform-ui/package.json:67 react 17.0.2
gamechanger-web/frontend/package.json:57 react 18.2.0

Would this mismatched version be an issue?

the react version here is 17.0.2. It is 18.2.0 in gamechanger-web/frontend/package.json:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant