Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use extensions.code to specify errors #3672

Merged
merged 3 commits into from
Feb 19, 2025
Merged

feat: use extensions.code to specify errors #3672

merged 3 commits into from
Feb 19, 2025

Conversation

ardatan
Copy link
Member

@ardatan ardatan commented Jan 16, 2025

Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 3b6aaf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
graphql-yoga Minor
@graphql-yoga/nestjs Major
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/apollo-managed-federation Major
@graphql-yoga/plugin-apollo-usage-report Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-jwt Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Jan 16, 2025

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 514974      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 104 MB  690 kB/s
     http_req_blocked.............................: avg=1.5µs    min=992ns    med=1.31µs   max=294.58µs p(90)=1.95µs   p(95)=2.14µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=143.46µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=362.91µs min=216.45µs med=330.87µs max=18.7ms   p(90)=473.06µs p(95)=496.2µs 
       { expected_response:true }.................: avg=362.91µs min=216.45µs med=330.87µs max=18.7ms   p(90)=473.06µs p(95)=496.2µs 
     ✓ { mode:graphql-jit }.......................: avg=291.06µs min=216.45µs med=274.69µs max=18.7ms   p(90)=307.57µs p(95)=321.97µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=498.22µs min=408.82µs med=475.08µs max=8.92ms   p(90)=518.74µs p(95)=566.27µs
     ✓ { mode:graphql-response-cache }............: avg=348.51µs min=267.99µs med=331.4µs  max=6.63ms   p(90)=365µs    p(95)=378.48µs
     ✓ { mode:graphql }...........................: avg=365.89µs min=281.38µs med=339.34µs max=14.43ms  p(90)=387.26µs p(95)=434.89µs
     ✓ { mode:uws }...............................: avg=347.86µs min=272.48µs med=329.6µs  max=6.42ms   p(90)=364.85µs p(95)=388.07µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 257487
     http_req_receiving...........................: avg=33.08µs  min=15.25µs  med=32.3µs   max=5.97ms   p(90)=39.65µs  p(95)=44.11µs 
     http_req_sending.............................: avg=8.67µs   min=6.03µs   med=7.56µs   max=323.36µs p(90)=11µs     p(95)=12.22µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=321.15µs min=188.35µs med=290.37µs max=18.58ms  p(90)=431µs    p(95)=452.02µs
     http_reqs....................................: 257487  1716.559506/s
     iteration_duration...........................: avg=577.53µs min=387.91µs med=541.45µs max=19.24ms  p(90)=690.85µs p(95)=719.46µs
     iterations...................................: 257487  1716.559506/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Copy link
Contributor

github-actions bot commented Jan 16, 2025

💻 Website Preview

The latest changes are available as preview in: https://e7a44134.graphql-yoga.pages.dev

@ardatan ardatan force-pushed the error-codes branch 2 times, most recently from cb866e0 to f0c10bc Compare January 16, 2025 19:22
@dotansimha
Copy link
Member

@ardatan lgtm! still in draft?

@ardatan ardatan marked this pull request as ready for review February 18, 2025 17:46
@ardatan
Copy link
Member Author

ardatan commented Feb 18, 2025

Actually it is ready to review!

@ardatan ardatan merged commit 5150146 into main Feb 19, 2025
25 checks passed
@ardatan ardatan deleted the error-codes branch February 19, 2025 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants