Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of twig_date_converter with own solution #46

Closed
alexmerlin opened this issue Jun 29, 2024 · 1 comment · Fixed by #48
Closed

Replace usage of twig_date_converter with own solution #46

alexmerlin opened this issue Jun 29, 2024 · 1 comment · Fixed by #48
Assignees
@Jurj-Bogdan

Comments

@alexmerlin
Copy link
Member

The issue:

  • Function 'twig_date_converter' is deprecated
  • Function 'twig_date_converter' is marked as @ internal

Where:
File: src/Extension/DateExtension.php
Lines: 43-44

Recommendation from vendor:
None

Todo:

  • Find a solution to achieve the same results with our own function directly in the DateExtension class.
  • Remove file psalm-baseline.xml
  • Remove line errorBaseline="psalm-baseline.xml" from psalm.xml
@alexmerlin alexmerlin changed the title Replace usage of twig_date_converter with own solution Replace usage of twig_date_converter with own solution Jun 29, 2024
@alexmerlin alexmerlin mentioned this issue Jun 29, 2024
Merged
@arhimede arhimede mentioned this issue Jul 31, 2024
Closed
@Jurj-Bogdan Jurj-Bogdan linked a pull request Jul 31, 2024 that will close this issue
psalm fix, replaced deprecated fuction call #48
Merged
@Jurj-Bogdan Jurj-Bogdan mentioned this issue Aug 1, 2024
Merged
@bidi47
Copy link
Member

bidi47 commented Aug 1, 2024

resolved in
#48

@bidi47 bidi47 closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jurj-Bogdan Jurj-Bogdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

psalm fix, replaced deprecated fuction call Jurj-Bogdan/dot-twigrenderer
3 participants
@alexmerlin @bidi47 @Jurj-Bogdan