Another attempt to fix the SDK insertion issue related to runtime/apphost downloads #77845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…indicate whether the restore should download those packages./
…s to the pack call too.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ToddGrun
commented
Mar 26, 2025
...ageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Mar 27, 2025
| <RuntimeIdentifiers Condition="'$(BaseOS)' != ''">$(BaseOS)</RuntimeIdentifiers> | ||
| <RuntimeIdentifiers Condition="'$(TargetRid)' == '' and '$(BaseOS)' == ''">win-x64;win-arm64;linux-x64;linux-arm64;linux-musl-x64;linux-musl-arm64;osx-x64;osx-arm64</RuntimeIdentifiers> | ||
|
|
||
| <!-- These indicate that the runtime/apphost packages should not be downloaded as part of build/restore --> |
There was a problem hiding this comment.
You might want to expand on this comment to explain why we're turning this off.
There was a problem hiding this comment.
will do in follow up
|
@ToddGrun I hope this works because it's nice and clean! |
dibarbet
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously mentioned that instead of modifying the RuntimeIdentifiers property to attempt to avoid downloading the runtime/apphost packages during build, we could use the EnableRuntimePackDownload/EnableAppHostPackDownload flags instead. Earlier attempts to use these failed, very likely due to a poor understanding by me how msbuild propogates properties.
This PR reinstates setting the RuntimeIdentifiers property in all context as we did before, and utilizes the flags instead to indicate that we only want these packages downloaded during the restore/pack that we do when packing.