-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Microsoft.DotNet.CilStrip.Sources from runtime-assets #383
Comments
@akoeplinger @fanyang-mono I think the readme should at least be updated. Do you think we can have an ILStrip replacement in .NET 9? |
If the functionality of writing a modified assembly to file and validating the new assembly are implemented, then probably yes. |
what is the status here? |
This one is tough because modern cecil rewrites tokens and aot images rely on exact values. Here's what I see our options are in .NET 9:
|
cc @vitek-karas |
Another (cheap) option that we discussed is using the functionality @fanyang-mono introduced in IlStrip which zeroes out method bodies for all methods instead of a subset, this feature only relies on SRM. It'd make the binary size on disk larger but the compressed size probably stays similar. |
https://github.com/dotnet/runtime-assets/blob/main/src/Microsoft.DotNet.CilStrip.Sources/README.md mentions that Microsoft.DotNet.CilStrip.Sources is a temporary copy and will be replaced during .NET 7.
Can these sources now be removed from the repository?
cc @steveisok
The text was updated successfully, but these errors were encountered: