Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Consider DangerousAddRef for JSObject #107974

Open
pavelsavara opened this issue Sep 18, 2024 · 1 comment
Open

[browser] Consider DangerousAddRef for JSObject #107974

pavelsavara opened this issue Sep 18, 2024 · 1 comment
Assignees
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Milestone

Comments

@pavelsavara
Copy link
Member

When we are marshaling JSObject to JS, should we DangerousAddRef on it for duration of the call ?
Our GC is scanning the stack so in most cases, that would be enough.

But there are few scenarios for which I'm not sure

  • marshaling array where JSObject is item in the array
  • multi-threaded stack frame which is passed between thread is allocated on a heap
  • NAOT-LLVM doesn't have conservative GC
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Sep 18, 2024
@pavelsavara pavelsavara added this to the 10.0.0 milestone Sep 18, 2024
@pavelsavara pavelsavara self-assigned this Sep 18, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

1 participant