-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should stack traces collected in filters have managed EH frames in them? #107995
Labels
area-ExceptionHandling-coreclr
in-pr
There is an active PR which will close this issue when it is merged
Milestone
Comments
dotnet-policy-service
bot
added
the
untriaged
New issue has not been triaged by the area owner
label
Sep 18, 2024
this looks related to new EH. Assume you get 8.0 if that is disabled? @janvorli fyi. |
Correct. |
janvorli
added a commit
to janvorli/runtime
that referenced
this issue
Oct 9, 2024
When StackTrace is created inside of an exception filter, it contains stack frames of the managed exception handling code, like System.Runtime.EH.RhThrowEx System.Runtime.EH.DispatchEx System.Runtime.EH.FindFirstPassHandler These should not occur on the stack trace as they are internal implementation detail of the new EH. This change fixes it by adding [StackTraceHidden] attribute to these methods. Close dotnet#107995
dotnet-policy-service
bot
added
in-pr
There is an active PR which will close this issue when it is merged
labels
Oct 9, 2024
github-actions bot
pushed a commit
that referenced
this issue
Oct 14, 2024
When StackTrace is created inside of an exception filter, it contains stack frames of the managed exception handling code, like System.Runtime.EH.RhThrowEx System.Runtime.EH.DispatchEx System.Runtime.EH.FindFirstPassHandler These should not occur on the stack trace as they are internal implementation detail of the new EH. This change fixes it by adding [StackTraceHidden] attribute to these methods. Close #107995
jeffschwMSFT
added a commit
that referenced
this issue
Oct 15, 2024
When StackTrace is created inside of an exception filter, it contains stack frames of the managed exception handling code, like System.Runtime.EH.RhThrowEx System.Runtime.EH.DispatchEx System.Runtime.EH.FindFirstPassHandler These should not occur on the stack trace as they are internal implementation detail of the new EH. This change fixes it by adding [StackTraceHidden] attribute to these methods. Close #107995 Co-authored-by: Jan Vorlicek <[email protected]> Co-authored-by: Jeff Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-ExceptionHandling-coreclr
in-pr
There is an active PR which will close this issue when it is merged
Reproduction:
dotnet run -f net8.0
:dotnet run -f net9.0
:I would also slightly question the double appearance of
TestStackTraceInFilterCallee
where other funclets get collapsed, but I suppose that has been this way for a long time.The text was updated successfully, but these errors were encountered: