SPMI: Record and replay notifyInstructionSetUsage properly
#112764
+49
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobbotsch
commented
Feb 20, 2025
| @@ -545,7 +545,7 @@ public void ExpandInstructionSetByImplication(TargetArchitecture architecture) | |||
| public static InstructionSet ConvertToImpliedInstructionSetForVectorInstructionSets(TargetArchitecture architecture, InstructionSet input) | |||
| { | |||
| switch(architecture) | |||
| switch (architecture) | |||
There was a problem hiding this comment.
#112302 enabled a new warning without updating the generator (the generated file was changed manually)
|
PTAL @dotnet/jit-contrib |
BruceForstall
approved these changes
Feb 20, 2025
tannergooding
approved these changes
Feb 21, 2025
This was referenced Feb 21, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #112756
We will still need to update coredistools, but we can procrastinate on that a bit longer.