[StyleCleanUp] Add missing accessibility modifiers on members (IDE0040) #10021
Conversation
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
| } | ||
| private static WriterState state = new Start(); | ||
|
|
||
| private Start() { } |
There was a problem hiding this comment.
Is this really the standard to put empty constructor/methods in a single line ? From a quick look, this doesn't seem to be the case in WPF, WinForms or Runtime and I couldn't find any documentation about it.
It's probably best to revert these changes to separate them and be able to discuss it separately.
There was a problem hiding this comment.
Good catch, that wasn't intentional but it's a setting. Like I've said, I just ran it.
I'll manually revert this later.
There was a problem hiding this comment.
With that being said though:
There's quite a lot! But I'll revert it, not a scope of the PR.
|
@h3xds1nz |
@dipeshmsft Means I didn't do these by hand, just applied fix per-project. |
h3xds1nz
force-pushed
the
xaml-accessibility-modifiers
branch
from
16c26f2 to
9e27641
Compare
h3xds1nz
changed the title
h3xds1nz
force-pushed
the
xaml-accessibility-modifiers
branch
from
9e27641 to
28e59e7
Compare
|
@harshit7962 Should be all done; I've built it on top of this one, felt easier. And yeah, solving IDE0040 resolved SA1400 occurrences as well, so I've removed both from |
h3xds1nz
changed the title
Fixes #10284
Fixes #10288
Description
Adds missing accessibility modifiers throughout the codebase. All of the edits were done automatically.
Customer Impact
Cleaner codebase.
Regression
No.
Testing
Local build.
Risk
Minimal.
Microsoft Reviewers: Open in CodeFlow