-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue with searchPredicate function second argument(searchTerm) #448
base: main
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit c80eef5 and detected 0 issues on this pull request. View more on Code Climate. |
c80eef5
to
56f387f
Compare
Pull Request Test Coverage Report for Build 1530
💛 - Coveralls |
@manish-dalal thanks for the CodeSandbox and the PR. Trying to understand the actual issue here: are you trying to make sure the "Searched String" label shows the search string as user typed it? Or is it that search is broken somehow? |
@mrchief thanks for the reply. I just want to implement case sensitive searching using searchPredicate props. On searchPredicate second argument(searchTerm), we are getting the actual string typed by the user. And currently, it is always the lowercase of the actual string. So I need the actual string, not the lowercase of that. For more clarification, I also updated the CodeSandbox example, please check react-dropdown-tree-select-searchpredicate-issue |
Correct |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
What does it do?
An issue with searchPredicate function second argument(searchTerm). Always received lowercase of search string. Needed the actual search string that is typed by a user.
Please check the issue on given eg:- react-dropdown-tree-select-searchpredicate-issue
Fixes # (issue)
Updated position of converting searchTerm to lowercase.
Type of change
Checklist: