Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid making global changes via UIManager.setLookAndFeel() #104

Closed
3 tasks
execveat opened this issue Mar 30, 2023 · 1 comment
Closed
3 tasks

Avoid making global changes via UIManager.setLookAndFeel() #104

execveat opened this issue Mar 30, 2023 · 1 comment
Labels
Bug Something isn't working Good First Issue Good for newcomers Help Wanted Extra attention is needed
Milestone

Comments

@execveat
Copy link
Contributor

In order to get InQL to look like main Burp interface, we're using UIManager.setLookAndFeel() as seen in https://github.com/doyensec/inql/blob/dev/python/inql/extender.py#L93. The style gets changed to FlatLaf before adding main UI elements, and it is reverted back after InQL is initiated.

It is a global modification so some elements that are created during the same time by Burp are ineriting FlatLaf as well, which results in graphical glitches. Find a way to solve / sidestep this problem.

  • Burp provides applyThemeToComponent() call which doesn't seem to have any effect. Are we using it incorrectly?
  • Is there a way to only set Look and Feel to explicitly selected components without changing global setting?
  • Finally, if nothing else works, implement a tight context manager that could be used just around the UI code.
@execveat execveat added Bug Something isn't working Help Wanted Extra attention is needed Good First Issue Good for newcomers labels Mar 30, 2023
@execveat execveat added this to the v5.0 milestone Mar 30, 2023
@execveat
Copy link
Contributor Author

Yeah, this seems totally unnecessary on the newer releases. I'm going to close the issue, and it can be re-raised if there are any graphical glitches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue Good for newcomers Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant