Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS Error in Web Editor #133

Closed
lokiuox opened this issue Oct 22, 2023 · 2 comments
Closed

CORS Error in Web Editor #133

lokiuox opened this issue Oct 22, 2023 · 2 comments
Labels
Bug Something isn't working Effort: a few hrs The implementation should require less than one day

Comments

@lokiuox
Copy link

lokiuox commented Oct 22, 2023

Describe the bug
Responses sent to web editor (GraphiQL, Voyager, etc) should be modified to inject CORS headers. At the moment this is already done on OPTIONS preflight requests, but from testing it looks like it's not enough and needs to be done on POST requests too.
@lokiuox lokiuox added Bug Something isn't working Effort: a few hrs The implementation should require less than one day labels Oct 22, 2023
@execveat
Copy link
Contributor

Ah, makes sense. Yeah, we should handle all possible conditions in the same way.

@lokiuox
Copy link
Author

lokiuox commented Nov 26, 2023

Fixed in 3b21d47

@lokiuox lokiuox closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Effort: a few hrs The implementation should require less than one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lokiuox @execveat