Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GraphQL versions are iterated in the wrong order #134

Closed
execveat opened this issue Nov 8, 2023 · 1 comment
Closed

GraphQL versions are iterated in the wrong order #134

execveat opened this issue Nov 8, 2023 · 1 comment
Assignees
@lokiuox
Labels
Bug Something isn't working Effort: a few hrs The implementation should require less than one day

Comments

@execveat
Copy link
Contributor

execveat commented Nov 8, 2023

We have multiple versions of GraphQL schemas in order to fall back to the most compatible. However, they are tried in the wrong order right now, starting with the oldest one.

I think the fix is as easy as reverting the iteration order in https://github.com/doyensec/inql/blob/dev/src/main/kotlin/inql/graphql/Introspection.kt#L23 , but please review this.
@execveat execveat added Bug Something isn't working Effort: a few hrs The implementation should require less than one day labels Nov 8, 2023
lokiuox added a commit that referenced this issue Nov 10, 2023
@lokiuox
Try introspection query from latest to earliest - Closes #134
9e80102
@lokiuox
Copy link

lokiuox commented Nov 10, 2023

Done!

@lokiuox lokiuox closed this as completed Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lokiuox lokiuox

Labels
Bug Something isn't working Effort: a few hrs The implementation should require less than one day
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lokiuox @execveat