Set minimum version of Gradio and rename height to max_height
#152
+28
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayqi
reviewed
Mar 3, 2025
| ) | ||
| time.sleep(10) | ||
| proc.send_signal(signal.SIGINT) | ||
| stdout, stderr = proc.communicate() |
There was a problem hiding this comment.
Set it make sense to check that the exit code is 0?
There was a problem hiding this comment.
you mean instead of killing the process? i think we'd just be checking that the sigint worked as expected, not anything about the cyfi explorer
There was a problem hiding this comment.
I guess it may be unnecessary depending on how the Gradio application works, but it's a way to test that it doesn't have a runtime error after the "Running on" string that you are testing for. It might be that it doesn't make sense for this case.
jayqi
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
This issue was not caught by weekly test runs because we didn't have any tests for cyfi/visualize.py. This PR adds a new test to ensure the explorer launches successfully