Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not build as shared library #1845

Open
antores opened this issue Nov 10, 2023 · 0 comments · May be fixed by #1990
Open

Does not build as shared library #1845

antores opened this issue Nov 10, 2023 · 0 comments · May be fixed by #1990

Comments

@antores
Copy link
Contributor

antores commented Nov 10, 2023

Describe the bug
Drogon does not build shared library because of using thread_local in lib/src/Utilities.cc.

To Reproduce
Build drogon with -DBUILD_SHARED_LIBS:BOOL=ON

Expected behavior
Successful build.

Desktop (please complete the following information):

  • OS: Windows 11
  • MSYS2 CLANG64

Additional context
Errors produced:

xxx/drogon/lib/src/Utilities.cc:1235:46: error: 'hash' cannot be thread local when declared 'dllexport'
 1235 |         thread_local trantor::utils::Hash256 hash;
      |                                              ^
xxx/drogon/lib/src/Utilities.cc:1236:29: error: 'i' cannot be thread local when declared 'dllexport'
 1236 |         thread_local size_t i = 0;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@antores