Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idea/Request] Add num_event_logs and num_trace_calls Fields to transactions Tables #4839

Open
MSilb7 opened this issue Nov 20, 2023 · 2 comments
Labels
enhancement New feature or request ready-for-review this PR development is complete, please review

Comments

@MSilb7
Copy link
Contributor

MSilb7 commented Nov 20, 2023

One method I've used to try to filter to "app-like" transactions is if there's either 1 internal transaction (2 traces) or any event logs emitted.

It's super computationally intensive to find transactions that do this (my method is to generate a list of txs in a CTE, versus doing two joins within the main query.

Ideas on how to solve:

  1. An "Augmented transactions" table spell and/or add columns to a materialized evms transactions table - Likely a huge drag on spellbook compute/capacity.
  2. In ingestion, count how many instances of the tx_hash there are in logs and traces, and add num_event_logs and num_trace_calls colums.
  3. Some fancy query magic that makes this easy? Ideally I'd be able to generate / filter on a count
@MSilb7 MSilb7 added the bug Something isn't working label Nov 20, 2023
@jeff-dude
Copy link
Member

fyi @hawkaa @dsalv @a-monteiro

@jeff-dude jeff-dude added enhancement New feature or request ready-for-review this PR development is complete, please review and removed bug Something isn't working labels Jan 24, 2024
@hawkaa
Copy link
Contributor

hawkaa commented Jan 25, 2024

Hi guys! Sorry I never responded in the ticket!

I truly understand the usecase, but we cannot add num_event_logs and num_trace_calls at this time. Adding a field and reprocessing all tables to add that field is currently not a trivial operation for us.

Do you have any options with matviews or spells?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready-for-review this PR development is complete, please review
Projects
None yet
Development

No branches or pull requests

3 participants