Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Seaport Trades Missing Trades #5548

Open
MSilb7 opened this issue Mar 10, 2024 · 0 comments
Open

[BUG] Seaport Trades Missing Trades #5548

MSilb7 opened this issue Mar 10, 2024 · 0 comments
Assignees
@0xRobin
Labels
bug Something isn't working NFT ready-for-review this PR development is complete, please review

Comments

@MSilb7
Copy link
Contributor

MSilb7 commented Mar 10, 2024 •
edited
Loading

Description

Seaport Optimism spell is missing this trade - via Sound Marketplace (seems to be the matchAdvancedOrders not being picked up).

Current behavior

Transaction does not appear

Expected behavior

Transaction appears

Impacted model(s)

seaport_optimism.trades, nft.trades

Possible solution

Hard to follow the spell logic, but seems like matchAdvancedOrders is not being picked up.

Discovered in #5547 - trying to add Base and Zora to the seaport models (also hard to do).
@MSilb7 MSilb7 added the bug Something isn't working label Mar 10, 2024
@jeff-dude jeff-dude added ready-for-review this PR development is complete, please review NFT labels Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xRobin 0xRobin

Labels
bug Something isn't working NFT ready-for-review this PR development is complete, please review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MSilb7 @0xRobin @jeff-dude