New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] naming issue, we named "transfers.eth" for just scroll #5707

Open

andrewhong5297 opened this issue Mar 29, 2024 · 1 comment

Assignees

Labels

Collaborator

andrewhong5297 commented Mar 29, 2024

We have:

transfers_ethereum.eth
transfers_base.eth
transfers_optimism.eth

and now transfers.eth should be transfers_scroll.eth and we should have a union all view spell for transfers.eth

The text was updated successfully, but these errors were encountered:

andrewhong5297 added the bug label

Member

jeff-dude commented Apr 7, 2024

we should actually move towards these being the only transfers spells (eth for example, more there):
https://github.com/duneanalytics/spellbook/blob/main/models/_sector/tokens/ethereum/tokens_ethereum_transfers.sql

we need to link up with the OP labs team to ensure we can remove these and replace with above

jeff-dude self-assigned this

jeff-dude added the in review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment