Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Safe Balances Spell not capturing safes and forward-filling data #6626

Open
safeintern opened this issue Aug 28, 2024 · 3 comments
Open
Assignees
Labels
bug Something isn't working in review Assignee is currently reviewing the PR

Comments

@safeintern
Copy link
Contributor

Description

The Safes balances spells (Ethereum, Optimism, Polygon) are not properly capturing safes and forward-filling data from previous dates

Current behavior

As you can see in these queries (ethereum, optimism, polygon, the number of wallets for each day in these spells drop off greatly.

Expected behavior

The reality is that because the spell entails forward-filling the data from previous dates, there shouldn't be a decrease in number of wallets for each day.

Impacted model(s)

safe_ethereum.balances
safe_optimism.balances
safe_polygon.balances

Possible solution

None. Thank you!

@safeintern safeintern added the bug Something isn't working label Aug 28, 2024
@safeintern
Copy link
Contributor Author

@jeff-dude can you please take a look 🙏🏻?

@jeff-dude
Copy link
Member

my first thoughts are:

  • can you confirm the tokens balances table you read from represents all of your intended safes each day, as in does it look like it forward fills for you? since you join the two, it would of course filter out if not
  • incremental models and window functions can be difficult to get to work together properly. when you read each incremental run, you filter down the source data to a particular timeframe. its possible its only getting a subset of addresses due to this

@jeff-dude jeff-dude self-assigned this Aug 28, 2024
@jeff-dude jeff-dude added the in review Assignee is currently reviewing the PR label Aug 28, 2024
@jeff-dude
Copy link
Member

@0xRobin to compare to arbitrum RWA PR on balances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in review Assignee is currently reviewing the PR
Projects
None yet
Development

No branches or pull requests

7 participants
@jeff-dude @safeintern and others