Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: item pagination 1️⃣ 2️⃣ 3️⃣ ... #392

Open
1 of 3 tasks
nelsonic opened this issue Jul 17, 2023 · 3 comments
Open
1 of 3 tasks

Feat: item pagination 1️⃣ 2️⃣ 3️⃣ ... #392

nelsonic opened this issue Jul 17, 2023 · 3 comments
Labels
discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality needs-design A feature idea that needs some interface design in order to be discussed/built. priority-3 Third priority. Considered "Nice to Have". Not urgent. T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App

Comments

@nelsonic
Copy link
Member

nelsonic commented Jul 17, 2023

As noted by @panoramix360 in #140 (comment)
when a person has many items
it can be useful to have pagination.

Context

I currently have 2x the number of items that the anonymous / guest person does in the MVP
and the interface is still perfectly manageable. see: https://mvp.fly.dev/stats
image
Not saying pagination isn't important; it definitely is.
But below 1k items it's not as important as some of the other features in the backlog; hence priority-3.
Yes, there are many items on the page (currently 281) but it's not reached the point of being unresponsive. ⏳ 💔
The https://mvp.fly.dev/?filter_by=done in incognito (not authenticated) loads in less than a 500ms for me:
image

Todo

  • @iteles to determine:

    • What the pagination should look like? ✨
      Can we just do the most basic thing like early Google did:
      image
      These days it's even simpler; just black and white with blue text links:
    image
    • How many items should the person or list have before it gets paginated? 💯

Once the acceptance criteria are defined we can proceed with prioritisation and implementation. 👍

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality technical A technical issue that requires understanding of the code, infrastructure or dependencies T4h Time Estimate 4 Hours priority-3 Third priority. Considered "Nice to Have". Not urgent. user-feedback Feedback from people using the App discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code needs-design A feature idea that needs some interface design in order to be discussed/built. labels Jul 17, 2023
@nelsonic
Copy link
Member Author

Tailwind UI - which we have unlimited access to - has a good-looking Pagination component:
https://tailwindui.com/components/application-ui/navigation/pagination
tailwind-UI-pagination

Thinking we will just use this and skip "design". 🤔
Your Thoughts? 💭

@panoramix360
Copy link
Collaborator

It's nice that my feedback was used to add new issues 🎉🎉

Since our design is simple and consistent, it should be enough to add the tailwind pagination.

@iteles
Copy link
Member

iteles commented Jul 17, 2023

I agree. For now, the tailwind implementation looks good and is in keeping with the rest of the design as @panoramix360 has noted 👏🏻

This can always be iterated on in the future.

Right now, I think we need to have this at a higher number of items (such as 100) in order to ensure we're not missing important tasks until other features such as #145 are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Share your constructive thoughts on how to make progress with this issue elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality needs-design A feature idea that needs some interface design in order to be discussed/built. priority-3 Third priority. Considered "Nice to Have". Not urgent. T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies user-feedback Feedback from people using the App
Projects
None yet
Development

No branches or pull requests

3 participants