Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fraud: Impact of fraud submission on x/dymns alias records #1078

Open
zale144 opened this issue Aug 9, 2024 · 5 comments
Open

fraud: Impact of fraud submission on x/dymns alias records #1078

zale144 opened this issue Aug 9, 2024 · 5 comments
Assignees
Labels

Comments

@zale144
Copy link
Contributor

zale144 commented Aug 9, 2024

When a fraud submission is made on a rollapp, there needs to be a defined way to handle the existing records of aliases tied to the rollapp in question.
Two possible solutions are:

  1. Move all aliases to a forked rollapp's ID:
  • Upon freezing the rollapp, immediately fork it
  • Migrate all the aliases to the forked rollapp
  1. Instead of tying aliases to the rollapp ID, tie them to the EIP155 part of the rollapp ID
  • All rollapps already comply with EIP155
  • The EIP155 stays the same across rollapp forks, so no need to do anything on fraud-submission/forking
  • There already is an index for EIP155 rollapp IDs
@VictorTrustyDev
Copy link
Contributor

@zale144 please provide me a hook when a RollApp changes it's chain-id because of whatever reason.

@zale144
Copy link
Contributor Author

zale144 commented Aug 9, 2024

@VictorTrustyDev Rollapps can only change the ID through forking. If we decide to tie the EIP155 part of the rollapp ID to aliases, then no need to do anything

@VictorTrustyDev
Copy link
Contributor

Move all aliases to a forked rollapp's ID what does that means? Itsn't that means RollApp change the Chain-ID?

@zale144
Copy link
Contributor Author

zale144 commented Aug 9, 2024

yes, when forking, the rollapp ID will be different. So, now the mapping of all the aliases should be migrated to the new rollapp ID.
But in case aliases are tied to the EIP155 ID, then forking will not change it, so no need to move the aliases

@VictorTrustyDev
Copy link
Contributor

not just that, configurations in Dym-Names records needs to be migrated also, so best way is to provide me a hook, thanks

@danwt danwt added the security label Aug 22, 2024
@danwt danwt changed the title Impact of fraud submission on x/dymns alias records fraud: Impact of fraud submission on x/dymns alias records Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants