Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/incentives: locks by denom cache is filled out of place #1143

Open
keruch opened this issue Aug 26, 2024 · 0 comments · May be fixed by #1173
Open

x/incentives: locks by denom cache is filled out of place #1143

keruch opened this issue Aug 26, 2024 · 0 comments · May be fixed by #1173
Assignees
@keruch
Labels
bug Something isn't working

Comments

@keruch
Copy link
Contributor

keruch commented Aug 26, 2024

Currently, locks by denom cache is cleaned and filled on every gauge processing which makes it useless. Its main idea is to persist the list of lockups throughout the whole gauge processing process to omit unnecessary requests to x/lockup, so filling it again and again on every gauge processing does nothing but additional overhead.
@keruch keruch added the bug Something isn't working label Aug 26, 2024
@keruch keruch self-assigned this Aug 26, 2024
@keruch keruch changed the title x/incentives: locks by denom cache is filled incorrectly x/incentives: locks by denom cache is filled out of place Aug 26, 2024
@keruch keruch mentioned this issue Aug 28, 2024
Closed
29 tasks
@mtsitrin mtsitrin linked a pull request Sep 11, 2024 that will close this issue
feat(streamer): distribute rewards immediately in the current block #1173
Open
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keruch keruch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@keruch